Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Improve strict search #139

Merged
merged 6 commits into from
Jan 27, 2024

Conversation

angelobreuer
Copy link
Owner

@angelobreuer angelobreuer commented Jan 27, 2024

This PR will solve various problems that were present with the old strict search solution. The default will stay to be the most pedantic option (Throw) which will fail if Lavalink4NET recognizes an attempt of the user trying to specify a search mode. However, this option also flagged search queries like PR: abc which may be valid search queries for some tracks. The option Resolve solves this problem by prepending the search prefix to those queries.

Please read the documentation of StrictSearchBehavior to learn more about the various new behaviors.

For users that previously enabled or disabled strict search, the option Throw matches the exact behavior as previously when strict search was enabled. The Passthrough options most likely matches the behavior as when strict search was disabled.

@angelobreuer angelobreuer added the enhancement New feature or request label Jan 27, 2024
@angelobreuer angelobreuer self-assigned this Jan 27, 2024
Copy link

Delta Summary

Generated on: 01/27/2024 - 13:29
Description Previous Current Delta
Coverage date: 01/23/2024 - 09:03 01/27/2024 - 13:29
Line coverage: 66.9% 66.9% 0.0%
Covered lines: 14084 14119 35
Coverable lines: 21044 21081 37
Total lines: 31235 31833 598
Branch coverage: 47.2% 47.4% 0.2%
Covered branches: 2226 2251 25
Total branches: 4714 4740 26
Method coverage: Feature is only available for sponsors

@angelobreuer angelobreuer merged commit 68a11c6 into dev Jan 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant