Add Lyrics.Java support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool 🎉 thank you a lot! |
|
Linking DuncteBot/java-timed-lyrics#4 |
|
Can you take a look at the modifications I made and check if they suit your use-case? Maybe there is something you find odd or could be improved |
|
Yes, it's perfect like this 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found great use of the Lyrics.Java plugin and think it would be great to have native support for it in Lavalink4NET!
This integration
NotifyLyricsLoadedAsync.GetCurrentTrackLyricsAsync,GetYoutubeLyricsAsync,GetGeniusLyricsAsyncandSearchAsyncextension methods toILavalinkApiClient.If looking forward to getting feedback on this PR and hopefully getting it merged!