Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NetCord to latest #196

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

update NetCord to latest #196

wants to merge 3 commits into from

Conversation

Pannoniae
Copy link

The latest version of NetCord does not work with the library anymore. This fixes that.

Copy link
Contributor

@KubaZ2 KubaZ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think the event handler could be removed after the first invocation.

src/Lavalink4NET.NetCord/GatewayClientWrapper.cs Outdated Show resolved Hide resolved
src/Lavalink4NET.NetCord/GatewayClientWrapper.cs Outdated Show resolved Hide resolved
@KubaZ2
Copy link
Contributor

KubaZ2 commented Dec 23, 2024

Is waiting for the Ready event actually necessary? The Shard and Id properties are set even before the first Ready is invoked. Is there other reason for waiting for it?

Pannoniae and others added 2 commits December 23, 2024 15:39
Co-authored-by: Kuba_Z2 <[email protected]>
Signed-off-by: Pannoniae <[email protected]>
Co-authored-by: Kuba_Z2 <[email protected]>
Signed-off-by: Pannoniae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants