Enforce consistent channel ordering in Pixie #1152
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Users may not always specify channels in strictly alphabetical order when running pixel-level Pixie. Additionally, Python's definition of sorting differs significantly from how we normally think of sorting, especially with capitalization. To prevent confusion, we need a consistent, non-stochastic ordering of channel names.
How did you implement your changes
Add a line to call Python's
sorted
function after defining thechannels
list. This ensureschannels
adheres to Python's sorting conventions.Remaining issues
Not sure if cross-platform compatibility will be an issue, but
sorted
should be OS-agnostic.