Ensure library matching uses the mass with the lowest mass error in case of ties #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
The
_matching_vec
helper function forlibrary_matching
previously assumed that there would only be one instance of a matching mass, so it took the first one every time. That can no longer be assumed: we will need to find the mass with the lowest mass error relative toppm
since there could be multiple masses.How did you implement your changes
Implement an additional control flow that iterates through each mass and finds the minimum across all masses in
library_peak_df
.Remaining issues
This is inherently a slower implementation since matches will take as long as non-matches. To speed this up, potentially iterate through a pre-sorted
library_peak_df
bym/z
value.