-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement spectra extraction workflow using pyTDFSDK
with parallelization
#26
Open
alex-l-kong
wants to merge
16
commits into
main
Choose a base branch
from
tdfsdk_workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
alex-l-kong
changed the title
Implement workflow using
Implement spectra extraction workflow using Oct 15, 2024
pyTDFSDK
and dask
pyTDFSDK
and dask
Pull Request Test Coverage Report for Build 11354056037Details
💛 - Coveralls |
alex-l-kong
changed the title
Implement spectra extraction workflow using
Implement spectra extraction workflow using Nov 11, 2024
pyTDFSDK
and dask
pyTDFSDK
with parallelization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Using SCiLS to extract spectra information is a long and cumbersome process, and we have no control over the development process. To expedite this, we implement our own functionality using Python.
How did you implement your changes
Initially,
timsconvert
was looked into as a solution. There were a few problem with this approach:.imzml
file definitionspyimzml
memory usageTo address the issues with SCiLS and
timsconvert
, thedask
library is leveraged. This offers us several benefits:map_partitions
function, code can run in parallel across several blocks in a DataFrame. This significantly reduces the time required to extract each spectra, which would normally happen on a per-spot basis. With a 16-core machine, we could theoretically achieve a 16x or even a 32x speedup.One challenge with SCiLS is the bins used to define the m/z peaks. This is done to reduce the number of m/z datapoints that are used for downstream analysis. However, because only raw spectra is extracted, we need to do the following:
The binning function is run using
raw_mz
/ 200 / 1000` to define the endpoints. This closely matches what SCiLS does, since the conversion happens to mDa.The
pyTDFSDK
library provides a simple connection/cursor workflow that allows us to easily query each spot for their corresponding spectra value.Remaining issues
pyTDFSDK
is a Windows-only package, meaning it will not be possible to test on Mac OS.Aggregating spots across different runs is still a challenge because de-identification is needed. This will be a WIP.