Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message input field not clearing #1091

Closed
wants to merge 2 commits into from

Conversation

SWITCHin2
Copy link

What does this PR do?

This PR fixes the an bug where typically input field in the chat box must be empty as soon as message is sent, but as the function is async and the clear statement was written at last the input field was clearing after some time, changed the orde, now as soon as the user message is displayed it will clear out the input field.
Fixes #(issue)
#1038

Screen.Recording.2024-11-08.at.9.14.55.AM.mov

Type of change

  • Bug fix (Changed execution order in the async funciton)

Screenshots

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ticket-booking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 3:48am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @SWITCHin2 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@SWITCHin2
Copy link
Author

@ankit071105 is this PR well and good to merge? If yes can you please merge it as tommorow is the last day of the gssoc-ext.

@SWITCHin2
Copy link
Author

@ankit071105 can you please merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext hacktoberfest-accepted level1 GirlScript Summer of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants