Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added work through vCenter Server for #1799 #1832

Merged
merged 5 commits into from
Oct 13, 2023
Merged

added work through vCenter Server for #1799 #1832

merged 5 commits into from
Oct 13, 2023

Conversation

ihumster
Copy link
Collaborator

@ihumster ihumster commented Aug 27, 2023 •
edited by mariolenz
Loading

SUMMARY

Fixes #1799

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_host_snmp

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/911c693e50b2456497da4acabc3abbc3

✔️ ansible-tox-linters SUCCESS in 8m 37s
✔️ build-ansible-collection SUCCESS in 9m 29s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 26s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 19m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 52m 38s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006329677 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 26s

@ihumster
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/dcaf25672e774a3eace535524d77394a

✔️ ansible-tox-linters SUCCESS in 8m 29s
✔️ build-ansible-collection SUCCESS in 9m 17s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 32s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 RETRY_LIMIT in 1h 00m 50s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 49m 41s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 50m 46s
✔️ ansible-galaxy-importer SUCCESS in 4m 52s

@ihumster
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/94154c0fccc1426d9c99d8ba79d652d0

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 33s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 03s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 04s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 49m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 51m 22s
✔️ ansible-galaxy-importer SUCCESS in 3m 37s

@ihumster ihumster linked an issue Sep 23, 2023 that may be closed by this pull request
Configure SNMP for given ESXi hosts via vCenter #1799
Closed
@ihumster ihumster requested a review from mariolenz October 11, 2023 09:38
mariolenz
mariolenz requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already released 3.10.0 on Monday.

Sorry, I didn't find the time to have a closer look. Will try to do this soon.

plugins/modules/vmware_host_snmp.py Outdated Show resolved Hide resolved
plugins/modules/vmware_host_snmp.py Outdated Show resolved Hide resolved
@mariolenz
Copy link
Collaborator

I think we should have a few integration tests for this. I'll have a look at this.

@mariolenz
Copy link
Collaborator

I've tried to add some integration tests. Let's see what happens :-)

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ca8683e557c14fa8a0e8cbabc22f8ab9

✔️ ansible-tox-linters SUCCESS in 8m 36s
✔️ build-ansible-collection SUCCESS in 9m 30s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 06s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 50s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 48m 55s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 1h 00m 13s
✔️ ansible-galaxy-importer SUCCESS in 3m 54s

@ihumster ihumster requested a review from mariolenz October 12, 2023 21:28
@ihumster
Copy link
Collaborator Author

LGTM

mariolenz
mariolenz approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the integration tests, configuring SNMP directly on an ESXi host and on an ESXi host / all hosts in a cluster through vCenter seem to work OK.

LGTM

Thanks @ihumster!

@mariolenz mariolenz added feature This issue/PR relates to a feature request has_issue mergeit labels Oct 13, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0dd061381c374cebad9f08ec643db838

✔️ ansible-tox-linters SUCCESS in 8m 26s
✔️ build-ansible-collection SUCCESS in 7m 31s
✔️ ansible-galaxy-importer SUCCESS in 5m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1699bcf into ansible-collections:main Oct 13, 2023
@ihumster ihumster deleted the vmware_snmp_rework branch October 13, 2023 09:53
mariolenz pushed a commit to mariolenz/community.vmware that referenced this pull request Oct 13, 2023
@ihumster @mariolenz
added work through vCenter Server for ansible-collections#1799 (ansib…
f5802fb 
…le-collections#1832)

added work through vCenter Server for ansible-collections#1799

SUMMARY
Fixes ansible-collections#1799
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_host_snmp

Reviewed-by: Mario Lenz <[email protected]>
@mariolenz mariolenz mentioned this pull request Oct 13, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 13, 2023
@mariolenz
added work through vCenter Server for #1799 (#1832) (#1874)
c85398d 
stable-3.x: Configure SNMP for ESXi hosts via vCenter

SUMMARY
Configure SNMP for ESXi hosts via vCenter
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_host_snmp
ADDITIONAL INFORMATION
Backport of #1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request has_issue mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure SNMP for given ESXi hosts via vCenter
2 participants
@ihumster @mariolenz