Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_deploy_ovf: Add option to source properties marked as ovf:user… #1838

Merged
merged 4 commits into from
Oct 17, 2023
Merged

vmware_deploy_ovf: Add option to source properties marked as ovf:user… #1838

merged 4 commits into from
Oct 17, 2023

Conversation

stxm
Copy link
Contributor

@stxm stxm commented Sep 7, 2023 •
edited
Loading

SUMMARY

This forces OVF properties marked as ovf:userConfigurable=false to become user configurable.

This is useful when deploying VCSA OVAs.

Fixes: #802

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_deploy_ovf: Add option to force applying non-user configurable properties

@stxm
Copy link
Contributor Author

stxm commented Sep 7, 2023

This is a repost of a stale issue/pr

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5d70ee0ac2984f93a77103205fe52de2

✔️ ansible-tox-linters SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 9m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 13s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 19m 33s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 9m 22s

@stxm
Copy link
Contributor Author

stxm commented Sep 11, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0e304d61e58b4818828c87293cf1af72

✔️ ansible-tox-linters SUCCESS in 8m 42s
✔️ build-ansible-collection SUCCESS in 9m 44s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 21m 58s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 05s

@stxm
Copy link
Contributor Author

stxm commented Sep 14, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f271adb1af764e3aa04877129dd78754

✔️ ansible-tox-linters SUCCESS in 8m 56s
✔️ build-ansible-collection SUCCESS in 9m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 19m 19s
✔️ ansible-galaxy-importer SUCCESS in 4m 27s

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1439f702b0b24d5494bce0399054a582

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 44s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 24s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006392597 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 55m 25s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 1h 04m 25s
✔️ ansible-galaxy-importer SUCCESS in 4m 40s

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3a6dae2710fa4964a0c7d349030c3b91

✔️ ansible-tox-linters SUCCESS in 8m 29s
✔️ build-ansible-collection SUCCESS in 9m 27s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 13s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 21m 12s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 50m 19s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 19m 46s
✔️ ansible-galaxy-importer SUCCESS in 5m 16s

@ihumster
Copy link
Collaborator

ihumster commented Oct 9, 2023

recheck

@ihumster
Copy link
Collaborator

ihumster commented Oct 9, 2023

@mariolenz need add this to current version and as backport to 3.x

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d91e34cef913438d9340ac0801d85abf

✔️ ansible-tox-linters SUCCESS in 8m 36s
✔️ build-ansible-collection SUCCESS in 9m 30s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 21s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 28s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 46m 19s
✔️ ansible-galaxy-importer SUCCESS in 4m 34s

@ihumster
Copy link
Collaborator

ihumster commented Oct 9, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5e50092c184a40618bd8e7c1b946e4b2

✔️ ansible-tox-linters SUCCESS in 8m 41s
✔️ build-ansible-collection SUCCESS in 9m 43s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 31s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 32m 31s
✔️ ansible-galaxy-importer SUCCESS in 3m 34s

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b81650e84cd74c4ea363495027332496

✔️ ansible-tox-linters SUCCESS in 8m 37s
✔️ build-ansible-collection SUCCESS in 9m 39s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 22m 15s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 59s

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a92a79a400784526a3d15cbe680208d8

✔️ ansible-tox-linters SUCCESS in 8m 37s
✔️ build-ansible-collection SUCCESS in 9m 54s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 21m 56s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 47s

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0d35116dc8fb4d118a50aecaa824fcb4

✔️ ansible-tox-linters SUCCESS in 8m 31s
✔️ build-ansible-collection SUCCESS in 9m 29s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 42s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 18m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 58m 11s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 51m 18s
✔️ ansible-galaxy-importer SUCCESS in 5m 15s

@ihumster ihumster requested a review from mariolenz October 10, 2023 18:23
@mariolenz mariolenz mentioned this pull request Oct 16, 2023
Closed
@mariolenz mariolenz closed this Oct 16, 2023
@mariolenz mariolenz reopened this Oct 16, 2023
@mariolenz mariolenz closed this Oct 16, 2023
@mariolenz mariolenz reopened this Oct 16, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/75a8ca683c774fdb98dac5bdd99708fd

✔️ ansible-tox-linters SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 9m 59s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 22s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 53s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 53m 06s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 47m 33s
✔️ ansible-galaxy-importer SUCCESS in 5m 50s

mariolenz
mariolenz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know how to test this at the moment, but the code LGTM.

What do you think @ihumster, should we merge? If you think that we should, you can add the mergeitlabel and it should be merged automatically.

@mariolenz mariolenz requested a review from ihumster October 17, 2023 08:39
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1d5ed2eeb3ff414da1c4ad297ed4463e

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 7m 34s
✔️ ansible-galaxy-importer SUCCESS in 3m 57s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3dec435 into ansible-collections:main Oct 17, 2023
18 checks passed
mariolenz pushed a commit to mariolenz/community.vmware that referenced this pull request Oct 17, 2023
@stxm @mariolenz
vmware_deploy_ovf: Add option to source properties marked as ovf:user… (
7674ee7 
ansible-collections#1838)

vmware_deploy_ovf: Add option to source properties marked as ovf:user…

SUMMARY
This forces OVF properties marked as ovf:userConfigurable=false to become user configurable.
This is useful when deploying VCSA OVAs.
Fixes: ansible-collections#802


ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_deploy_ovf: Add option to force applying non-user configurable properties

Reviewed-by: Mario Lenz <[email protected]>
Reviewed-by: Alexander Nikitin <[email protected]>
@mariolenz mariolenz mentioned this pull request Oct 17, 2023
Merged
@mariolenz
Copy link
Collaborator

@mariolenz need add this to current version and as backport to 3.x

#1883

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 17, 2023
@mariolenz
vmware_deploy_ovf: Add option to source properties marked as ovf:user… (
ff98f59 
#1838) (#1883)

vmware_deploy_ovf: Add new parameter enable_hidden_properties

SUMMARY
This forces OVF properties marked as ovf:userConfigurable=false to become user configurable.
This is useful when deploying VCSA OVAs.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_deploy_ovf
ADDITIONAL INFORMATION
Backport #1838
@stxm stxm deleted the vmware_deploy_ovf_patch branch October 19, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

@ihumster ihumster ihumster approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to deploy VCSA appliance with OVF properties using ansible
3 participants
@stxm @ihumster @mariolenz