vmware_host_acceptance: Remove acceptance_level #1877

mariolenz · 2023-10-13T16:18:09Z

SUMMARY

Removing acceptance_level and move its options to state so that

acceptance_level: 'community'
state: present

will become

state: 'community'

This also means there won't be a state list anymore. In order to get information about the current acceptance level, I will introduce a new module vmware_host_acceptance_info.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

vmware_host_acceptance
vmware_host_acceptance_info

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2023-10-13T16:27:30Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f0e1c3b6c2c14994a1938e9f15af949a

❌ ansible-tox-linters FAILURE in 8m 37s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

softwarefactory-project-zuul · 2023-10-13T18:25:15Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a46ef046f52c4e11a8291c6de0887400

✔️ ansible-tox-linters SUCCESS in 8m 37s
✔️ build-ansible-collection SUCCESS in 9m 30s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 47s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006485528 failed in 0s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 34m 09s
✔️ ansible-galaxy-importer SUCCESS in 5m 22s

softwarefactory-project-zuul · 2023-10-14T07:04:38Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/490a6a099ef744ebbd9aef92adbd30d8

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 39s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 21m 25s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 1h 08m 55s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 59m 56s
✔️ ansible-galaxy-importer SUCCESS in 3m 58s

mariolenz · 2023-10-14T09:44:36Z

recheck

softwarefactory-project-zuul · 2023-10-14T11:01:49Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/42b2bc77843241228ff179165dcd6ef6

✔️ ansible-tox-linters SUCCESS in 8m 30s
✔️ build-ansible-collection SUCCESS in 9m 24s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 59s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006490258 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 59m 14s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 48m 08s
✔️ ansible-galaxy-importer SUCCESS in 5m 07s

mariolenz · 2023-10-14T13:39:40Z

recheck

softwarefactory-project-zuul · 2023-10-14T14:10:39Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ee5a787050624039ad8991101b7bf7bb

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 29s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 19m 48s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 17s

mariolenz · 2023-10-14T14:12:13Z

recheck

softwarefactory-project-zuul · 2023-10-14T14:20:51Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/613f3b063d9142149a31150a68133dc3

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 7m 56s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

mariolenz · 2023-10-14T14:33:51Z

recheck

softwarefactory-project-zuul · 2023-10-14T14:42:17Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f8e49e483fce4bbdb4fae16b09c829fb

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 7m 52s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

mariolenz · 2023-10-14T14:56:14Z

recheck

softwarefactory-project-zuul · 2023-10-14T17:16:45Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1599fa8e1a18461d9a5e9091b8a71489

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 8m 06s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

mariolenz · 2023-10-14T17:19:33Z

recheck

softwarefactory-project-zuul · 2023-10-14T17:46:49Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/38520153accf43b1b418430590b4b902

✔️ ansible-tox-linters SUCCESS in 10m 15s
✔️ build-ansible-collection SUCCESS in 12m 10s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 12m 35s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 50s

mariolenz · 2023-10-14T18:03:37Z

recheck

softwarefactory-project-zuul · 2023-10-14T19:07:29Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/db3eb29ef57343d4b00cd840a310aa03

✔️ ansible-tox-linters SUCCESS in 8m 42s
✔️ build-ansible-collection SUCCESS in 9m 28s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 22s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 50m 58s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

mariolenz · 2023-10-15T06:47:40Z

recheck

softwarefactory-project-zuul · 2023-10-15T07:16:46Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c67c0b1ec9e044d3b848ea9538831c01

✔️ ansible-tox-linters SUCCESS in 8m 53s
✔️ build-ansible-collection SUCCESS in 9m 34s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 15m 56s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 12s

mariolenz · 2023-10-15T07:21:17Z

recheck

softwarefactory-project-zuul · 2023-10-15T07:53:32Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b0bea727ab2843e8a5505787fcd6b99f

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 57s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 19m 28s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 55s

mariolenz · 2023-10-15T08:53:44Z

recheck

softwarefactory-project-zuul · 2023-10-15T10:04:36Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b22d34f01c444a73bf95c10846eb2488

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 28s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 13s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 18m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 58m 37s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 47m 18s
✔️ ansible-galaxy-importer SUCCESS in 4m 09s

mariolenz · 2023-10-15T12:54:54Z

@ihumster Could you please review? I think it should be OK now, but you might see something that I've overlooked.

ihumster

Looks nice for both modules.

mariolenz · 2023-10-15T13:51:27Z

Thanks for reviewing @ihumster!

softwarefactory-project-zuul · 2023-10-15T14:04:00Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0d96df0b33c94cffaa570fe92ba3cb1c

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 7m 45s
✔️ ansible-galaxy-importer SUCCESS in 3m 36s

vmware_host_acceptance_info: Fix module doc SUMMARY Fix documentation of new module vmware_host_acceptance_info. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_host_acceptance_info ADDITIONAL INFORMATION #1877 Reviewed-by: Alexander Nikitin <[email protected]>

mariolenz added bug This issue/PR relates to a bug WIP Work in progress new_module New module tests tests labels Oct 13, 2023

mariolenz force-pushed the issue1872 branch 7 times, most recently from d4ea0cc to ccec2e2 Compare October 13, 2023 17:32

vmware_host_acceptance: Remove acceptance_level

717d7a0

mariolenz force-pushed the issue1872 branch from 560cc54 to 717d7a0 Compare October 14, 2023 04:24

mariolenz closed this Oct 14, 2023

mariolenz reopened this Oct 14, 2023

mariolenz changed the title ~~[WIP] vmware_host_acceptance: Remove acceptance_level~~ vmware_host_acceptance: Remove acceptance_level Oct 15, 2023

mariolenz removed the WIP Work in progress label Oct 15, 2023

mariolenz requested a review from ihumster October 15, 2023 12:53

ihumster approved these changes Oct 15, 2023

View reviewed changes

mariolenz added the mergeit label Oct 15, 2023

softwarefactory-project-zuul bot merged commit 71b7db7 into ansible-collections:main Oct 15, 2023
12 checks passed

mariolenz deleted the issue1872 branch October 15, 2023 14:05

mariolenz mentioned this pull request Oct 22, 2023

vmware_host_acceptance_info: Fix module doc #1887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vmware_host_acceptance: Remove acceptance_level #1877

vmware_host_acceptance: Remove acceptance_level #1877

mariolenz commented Oct 13, 2023

softwarefactory-project-zuul bot commented Oct 13, 2023

softwarefactory-project-zuul bot commented Oct 13, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

ihumster left a comment

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

vmware_host_acceptance: Remove acceptance_level #1877

vmware_host_acceptance: Remove acceptance_level #1877

Conversation

mariolenz commented Oct 13, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Oct 13, 2023

softwarefactory-project-zuul bot commented Oct 13, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 14, 2023

softwarefactory-project-zuul bot commented Oct 14, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023

mariolenz commented Oct 15, 2023

ihumster left a comment

Choose a reason for hiding this comment

mariolenz commented Oct 15, 2023

softwarefactory-project-zuul bot commented Oct 15, 2023