-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vmware_guest.py docs #2272
base: main
Are you sure you want to change the base?
Conversation
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 40s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 5m 02s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 51s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 29s |
I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon. |
SUMMARY
None of
name
orvlan
is in fact required. For correct operation either one can be specified.ISSUE TYPE
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
This cost us about 2 hours of debugging because we thought that vlan is required. When we specified both name and vlan, another network was picked than we specified in name because vlan takes precedence and there was another network available with the same vlan id.
This PR might be worth backporting to all version where this applies.
Relevant code section:
community.vmware/plugins/modules/vmware_guest.py
Lines 1811 to 1812 in e249a03