Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov #448

Closed

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Nov 17, 2023

Disable Codecov for now. I don't think it provides valuable information to us, at least not at the moment.

Copy link
Contributor

@mariolenz
Copy link
Collaborator Author

recheck

Copy link
Contributor

@mariolenz mariolenz closed this Nov 17, 2023
@mariolenz mariolenz reopened this Nov 17, 2023
Copy link
Contributor

@mariolenz mariolenz closed this Nov 17, 2023
@mariolenz mariolenz reopened this Nov 17, 2023
Copy link
Contributor

@mariolenz
Copy link
Collaborator Author

@GomathiselviS What do you think about this? I really don't see any valuable information for us from Codcov, it only clutters PRs imho.

@GomathiselviS
Copy link
Contributor

@GomathiselviS What do you think about this? I really don't see any valuable information for us from Codcov, it only clutters PRs imho.
I prefer not to disable Codecov because it offers code coverage feedback directly in pull requests. This helps contributors comprehend how their changes affect test coverage, encouraging them to include tests for their modifications. We might consider implementing a threshold to determine whether the test should pass or fail based on the coverage percentage achieved.

@mariolenz
Copy link
Collaborator Author

I prefer not to disable Codecov because it offers code coverage feedback directly in pull requests. This helps contributors comprehend how their changes affect test coverage, encouraging them to include tests for their modifications. We might consider implementing a threshold to determine whether the test should pass or fail based on the coverage percentage achieved.

OK

@mariolenz mariolenz closed this Nov 18, 2023
@mariolenz mariolenz deleted the 20231117-code-coverage branch November 18, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants