Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified 2 appliance targets #568

Conversation

prabinovRedhat
Copy link
Collaborator

  • Modified appliance_system test to run on real vCenter env
  • Modified appliance_time test to run on real vCenter env

@prabinovRedhat
Copy link
Collaborator Author

Please take a look when you have time @anna-savina @shellymiron

@prabinovRedhat prabinovRedhat force-pushed the continue_appliance_work branch from 2226ee2 to 114c0c3 Compare December 18, 2024 11:47
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (07a9611) to head (114c0c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         145      145           
  Lines       11395    11395           
  Branches     2261     2261           
=======================================
  Hits         4222     4222           
  Misses       7173     7173           
Flag Coverage Δ
sanity 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shellymiron
Copy link
Collaborator

/lgtm

@prabinovRedhat
Copy link
Collaborator Author

mergeit

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e9786c0ea2be49ed98922185a0582afb

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 51s
✔️ build-ansible-collection SUCCESS in 7m 38s
✔️ ansible-galaxy-importer SUCCESS in 4m 05s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 272fe93 into ansible-collections:main Dec 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants