-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge devel to main for release #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Dan D <[email protected]>
… skipped Signed-off-by: Ionut Pruteanu <[email protected]>
…xing issue #105) Signed-off-by: Ionut Pruteanu <[email protected]>
fixes a typo in 2.1.1.1
…ving_var_for_r1_1_2_1_from_when Fixing conditional by removing extra condition in when rule1.1.2.1(fi…
2023 September Updates: Typo fixes and Implemented Standards
…tional Fixing conditional for rule2.2.2(issue #108), to prevent always being…
Signed-off-by: Bernd Grobauer <[email protected]>
Signed-off-by: Bernd Grobauer <[email protected]>
… 1.1.1.2 Signed-off-by: Bernd Grobauer <[email protected]>
…e_1_1_1_2 Fixing precondition for rule 1.1.1.2
… WITH '/boot/grub/grub.cfg' Signed-off-by: Ionut Pruteanu <[email protected]>
Signed-off-by: Dan D <[email protected]>
Signed-off-by: Bernd Grobauer <[email protected]>
…ub_cfg_filepath_value Changing value in defaults/main.yml: Replaced '/etc/default/grub.cfg'…
Fixing name of gmd3 config file in Control 1.8.3.
Signed-off-by: Ionut Pruteanu <[email protected]>
fixes cron and mail.warn rsyslog entry
Currently a multi-line banner will cause the YAML file to be invalid. This change ensures a valid YAML format without changing behavior. Signed-off-by: tomi-bigpi <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v3.2.0 → v4.4.0](pre-commit/pre-commit-hooks@v3.2.0...v4.4.0) - [github.com/gitleaks/gitleaks: v8.17.0 → v8.18.0](gitleaks/gitleaks@v8.17.0...v8.18.0) - [github.com/ansible-community/ansible-lint: v6.17.2 → v6.20.2](ansible/ansible-lint@v6.17.2...v6.20.2)
…nfig [pre-commit.ci] pre-commit autoupdate
…nditional Changing 3.2.2 conditional
Signed-off-by: Bernd Grobauer <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Collections now pulled from git
Siemens/feat/squashfs check hangs
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v6.20.3 → v6.21.1](ansible/ansible-lint@v6.20.3...v6.21.1)
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
…nfig [pre-commit.ci] pre-commit autoupdate
Community work fix
Signed-off-by: Dan D <[email protected]>
Signed-off-by: Dan D <[email protected]>
if timesyncd is not installed 2.1.1.1 errors
found cron regex typo
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Workflow galaxy
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
…es or IP addresses, instead of a json encoded list or objects. Also added the section label [Time] to fix the log message "/etc/systemd/timesyncd.conf.d/50-timesyncd.conf:8: Assignment outside of section. Ignoring." Signed-off-by: Jason Hendry <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v6.21.1 → v6.22.0](ansible/ansible-lint@v6.21.1...v6.22.0)
…nfig [pre-commit.ci] pre-commit autoupdate
fix: #161 NTP should be a space-separated list of NTP server host nam…
update wording and typos
georgenalen
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Many updates
precommit
lint
workflows
issues and PRs
Issue Fixes:
thanks to @bgro
#131
#148
thanks to @tomi-bigpi
#123
thanks to @jovial
#132
thanks to @paulquevedojdrf
#135
#136
thanks to @zac90
#138
#139
#140
#141
#142
#143
#145
thanks to @dderemiah
#146
thanks to @lozzolloz
#151
#153
#154
PRs
#107
#108
#109
#110
#113
#116
#118
#119
Enhancements:
Huge thanks to the discord community Thanks to @loz for all the testing and feedback
1.7.1 added dymamic check to audit
4.1.4.1 & 4.1.4.5 improved logic
ssh default groups emptied
bootloader password default now false and improved test
audit updates for documentation
1.1.1.2 conditional logic improvement
4.2.3 ensure checking for hidden logfiles
sshd ciphers/macs/kex all now lists to allow greater testing
correction to cis level
section 6.1 mode updates
@petri and @loz for all the testing on this partcular issue
rule 5.4.2 logic and extra variables added in defaults/main.yml
How has this been tested?:
Many times manually and pipelines during PRs