fix: #172 checks if ipv6.disable is present in GRUB_CMDLINE_LINUX bef… #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR nice little tidy up. I was considering using the ansible facts for the GRUB_CMDLINE as a way to test also. Many thanks again uk-bolly |
…MDLINE_LINUX before appending it to prevent duplication Signed-off-by: Jason Hendry <[email protected]>
…s that do the same thing. Signed-off-by: Jason Hendry <[email protected]>
Jason-Hendry
force-pushed
the
fix/ipv6disable-grub-mutliple-entries
branch
from
8f33536 to
4e67550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if ipv6.disable is present in GRUB_CMDLINE_LINUX before appending it to prevent duplication
Overall Review of Changes:
Adds a task to get the current value before appending
Adds a second condition to only append it wasn't changed by the previous task and doesn't already exist in the file
Issue Fixes:
172
Enhancements:
none
How has this been tested?:
A physical server, running Ubuntu 22.04 minimal installation, was already provisioned then ran the playbook multiple times.
With existing different value
With no existing value
When the current value matches the expected value
