Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit standalone #177

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Audit standalone #177

merged 8 commits into from
Nov 21, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Nov 20, 2023 •
edited
Loading

Overall Review of Changes:
Added ability with select vars to run only the audit using the remediate playbook

  • updated goss binary to 0.4.4
  • moved majority of audit variables to vars/audit.yml
  • new function to enable audit_only using remediation
  • removed some dupes in audit config

How has this been tested?:
Manually, with and without the options set

@uk-bolly
Additional config for audit only
f5a2802 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated var naming
b03f94e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen November 20, 2023 16:16
georgenalen
georgenalen previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@uk-bolly
added debug for test
f1d2565 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added non injected facts
d4a4778 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed debug
2bfa448 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
tidy up variable locations
38b743b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
2293321 
Signed-off-by: Mark Bolwell <[email protected]>
georgenalen
georgenalen approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@uk-bolly uk-bolly merged commit fba3678 into devel Nov 21, 2023
3 checks passed
@uk-bolly uk-bolly deleted the audit_standalone branch November 21, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uk-bolly @georgenalen