Fixing issue https://github.com/ansible-lockdown/UBUNTU22-CIS/issues/180 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-baseline-automations/ansible-lockdown/ubuntu22-cis/-/issues/69! Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Dan D <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v6.22.0 → v6.22.1](ansible/ansible-lint@v6.22.0...v6.22.1)
Signed-off-by: Dan D <[email protected]>
missing grub check fails when using sysctl
Fixes a typo that keeps Chr0ny from working
…e Defaults in sudoers Signed-off-by: Dan D <[email protected]>
…mit-ci-update-config [pre-commit.ci] pre-commit autoupdate
Changed regex to account for different whitespace and grouping
Signed-off-by: Dan D <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v6.22.1 → v6.22.2](ansible/ansible-lint@v6.22.1...v6.22.2)
improves command collection to match CIS bench
…mit-ci-update-config [pre-commit.ci] pre-commit autoupdate
Signed-off-by: joshavant <[email protected]>
…isable-mechanism Respect ipv6_disable mechanism
|
Thank you for updating all of your branches. If i could request that you do it again, this should enable this older PR to complete as well. Many thanks uk-bolly |
|
I have added a warning that PRs are stale if your branch is not upto date, You will see that we have seen this on a number of your PRs. Hoping this helps us to highlight issues so we can get these resolved. Many thanks uk-bolly |
…r-baseline-automations/ansible-lockdown/ubuntu22-cis/-/issues/69! Signed-off-by: Diana-Maria Dumitru <[email protected]>
…om:siemens/UBUNTU22-CIS into siemens/feat/rule_5_4_3_pamd_configuration
…r-baseline-automations/ansible-lockdown/ubuntu22-cis/-/issues/69! Signed-off-by: Diana-Maria Dumitru <[email protected]>
…r-baseline-automations/ansible-lockdown/ubuntu22-cis/-/issues/69! Signed-off-by: Diana-Maria Dumitru <[email protected]>
…om:siemens/UBUNTU22-CIS into siemens/feat/rule_5_4_3_pamd_configuration
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…om:siemens/UBUNTU22-CIS into siemens/feat/rule_5_4_3_pamd_configuration
|
Thank you for letting me know! I have re-updated my branches and I have also fixed some indentation issues on some PRs. Now all the checks have passed on all PRs, hope this helps! |
DianaMariaDDM
dismissed
uk-bolly’s stale review
The merge-base changed after approval.
uk-bolly
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
This is the solution provided for issue 180.
It uses the same ansible module as before, only that it adds another task that edits the necessary line right above the
password [success=1 default=ignore] pam_unix.so obscure yescryptline.Issue Fixes:
Enhancements:
None
How has this been tested?:
Tested on my local test environment.