Skip to content

Commit

Permalink
Remove redundant list creation
Browse files Browse the repository at this point in the history
  • Loading branch information
dsoumis committed Oct 10, 2023
1 parent 300a610 commit cc292e4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion roles/jws/tasks/fastpackage.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
- name: "Check if \"{{ packages_list | join(', ') }}\" packages are already installed" # noqa command-instead-of-module this runs faster
- name: "Check if \"{{ packages_list | join(', ') }}\" packages are already installed" # noqa command-instead-of-module this runs faster
ansible.builtin.command: "rpm -q {{ packages_list | join(' ') }}"
register: rpm_info
changed_when: False
Expand Down
2 changes: 1 addition & 1 deletion roles/jws/tasks/java_install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
block:
- name: "Add 'java-{{ jws_java_version }}-openjdk-headless' to dependencies list"
ansible.builtin.set_fact:
jws_dependencies_list: "{{ jws_dependencies_list + [ 'java-{{ jws_java_version }}-openjdk-headless' ] }}"
jws_dependencies_list: "{{ jws_dependencies_list + ['java-{{ jws_java_version }}-openjdk-headless'] }}"

- name: "Determine JAVA_HOME for selected JVM RPM"
ansible.builtin.set_fact:
Expand Down
2 changes: 1 addition & 1 deletion roles/jws/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

- name: "Add 'openssl' and 'apr' to dependencies list required for natives (if enabled)"
ansible.builtin.set_fact:
jws_dependencies_list: "{{ jws_dependencies_list + [ 'openssl', 'apr' ] }}"
jws_dependencies_list: "{{ jws_dependencies_list + ['openssl', 'apr'] }}"
when: jws_native

- name: "Include tasks for Java installation (if Java version is provided)"
Expand Down

0 comments on commit cc292e4

Please sign in to comment.