This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Remove console.debug statements #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to #540
for more information, see https://pre-commit.ci
priyamsahoo
suggested changes
Feb 13, 2023
|
@sc68cal @priyamsahoo Yep, we need these logged, so we need an alternative that is safe to use that would not break the protocol. I wonder if could monkeypatch console logging to produce messaging that are not breaking the protocol, like JSON ones? If is not possible to patch console logging to make it safe to use, we probably want to add a linter check for preventing accidental introduction in the future. I wonder if eslint can help us achieve that. |
|
Attempted to bring this issue up, but I do not have time to spend on this, more than what I did in January. |
JosBritton
added a commit
to JosBritton/ansible-language-server
that referenced
this pull request
Oct 18, 2023
Do not log validation status on stdout, use connection logs instead. See #540, ansible#541
priyamsahoo
added a commit
that referenced
this pull request
Oct 23, 2023
* Stdio patch Do not log validation status on stdout, use connection logs instead. See #540, #541 * Fix: use optional chaining for connection as it may not exist for purposes of testing. --------- Co-authored-by: Priyam Sahoo <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to ansible/vscode-ansible#1142