Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable unimplemented tests #1691

Merged
merged 7 commits into from
Jan 28, 2025
Merged

Conversation

b-matteo
Copy link
Contributor

@b-matteo b-matteo commented Jan 27, 2025

Skip export tests for formats not yet implemented into CoreService

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Skip export tests for formats not yet implemented into CoreService
@b-matteo b-matteo added bug Something isn't working testing Anything related to tests labels Jan 27, 2025
@b-matteo b-matteo self-assigned this Jan 27, 2025
@b-matteo b-matteo requested a review from a team as a code owner January 27, 2025 09:41
@github-actions github-actions bot removed the testing Anything related to tests label Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (03a5774) to head (66b8691).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          87       87           
  Lines        7143     7143           
=======================================
  Hits         6527     6527           
  Misses        616      616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @b-matteo

@RobPasMue RobPasMue enabled auto-merge (squash) January 28, 2025 08:52
@RobPasMue RobPasMue merged commit 0c00cdb into main Jan 28, 2025
49 checks passed
@RobPasMue RobPasMue deleted the fix/coreservice_unimplemented_formats branch January 28, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants