Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re enable fmd tests #1711

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: re enable fmd tests #1711

merged 4 commits into from
Feb 7, 2025

Conversation

b-matteo
Copy link
Contributor

Description

FMD import and export tests had been mistakenly disabled during the PyAnsys Geometry blitz. now we shall re enable them.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@b-matteo b-matteo self-assigned this Jan 31, 2025
@b-matteo b-matteo requested a review from a team as a code owner January 31, 2025 15:27
@b-matteo b-matteo added the testing Anything related to tests label Jan 31, 2025
RobPasMue
RobPasMue previously approved these changes Jan 31, 2025
@github-actions github-actions bot added bug Something isn't working and removed testing Anything related to tests labels Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (f79a249) to head (8b9e67b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1711   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          91       91           
  Lines        8006     8006           
=======================================
  Hits         7281     7281           
  Misses        725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue enabled auto-merge (squash) February 7, 2025 06:49
@RobPasMue RobPasMue merged commit 3a3b2a6 into main Feb 7, 2025
50 checks passed
@RobPasMue RobPasMue deleted the fix/re_enable_fmd branch February 7, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants