Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sketch plane for imprint/project curves #1715

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Feb 3, 2025

Description

Previously the plane for curves to imprint or project was hardcoded as XY on the backend. I changed this to supply it from the sketch.

Issue linked

#1622

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Feb 3, 2025
@jonahrb jonahrb requested a review from a team as a code owner February 3, 2025 20:06
@jonahrb jonahrb added the bug Something isn't working label Feb 3, 2025
@jonahrb jonahrb linked an issue Feb 3, 2025 that may be closed by this pull request
2 tasks
@jonahrb
Copy link
Contributor Author

jonahrb commented Feb 3, 2025

Requires new docker image and protos

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jonahrb!

@RobPasMue
Copy link
Member

We will need protos update (already triggered) and new images as well. Working on it!

@RobPasMue RobPasMue enabled auto-merge (squash) February 4, 2025 11:45
@RobPasMue RobPasMue merged commit a28172c into main Feb 4, 2025
47 checks passed
@RobPasMue RobPasMue deleted the fix/imprint-project-plane branch February 4, 2025 12:14
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (1a192a7) to head (8aa903c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1715   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          91       91           
  Lines        7995     7995           
=======================================
  Hits         7278     7278           
  Misses        717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

body.imprint_projected_curves() not working as expected
3 participants