Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: launch core service from envar #1716

Merged
merged 10 commits into from
Feb 4, 2025
Merged

feat: launch core service from envar #1716

merged 10 commits into from
Feb 4, 2025

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Feb 3, 2025

Description

Allow the option to define ANSYS_GEOMETRY_SERVICE_ROOT envar to provide path to CoreService executable instead of assuming the unified install.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Feb 3, 2025
@jonahrb jonahrb requested a review from a team as a code owner February 3, 2025 22:11
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 3, 2025
@jonahrb
Copy link
Contributor Author

jonahrb commented Feb 3, 2025

@RobPasMue i will defer to you here. I have no experience with the launcher code so i just did what was minimally invasive and functional.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 90.94%. Comparing base (a28172c) to head (2dac111).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 21.73% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
- Coverage   91.03%   90.94%   -0.09%     
==========================================
  Files          91       91              
  Lines        7995     8006      +11     
==========================================
+ Hits         7278     7281       +3     
- Misses        717      725       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good but we should document this somewhere - probably in the docs page where we are showing how to launch the services. Would you mind adding it there @jonahrb? Apart from that, all good - I'll approve once the docs are up.

@jonahrb jonahrb requested a review from PipKat as a code owner February 4, 2025 13:52
@jonahrb jonahrb requested a review from RobPasMue February 4, 2025 13:54
@jonahrb jonahrb enabled auto-merge (squash) February 4, 2025 14:33
@RobPasMue RobPasMue disabled auto-merge February 4, 2025 15:19
@RobPasMue
Copy link
Member

Need to do a local mod... I'll ping you asap

@RobPasMue RobPasMue enabled auto-merge (squash) February 4, 2025 16:12
@RobPasMue RobPasMue merged commit 9d62787 into main Feb 4, 2025
47 checks passed
@RobPasMue RobPasMue deleted the feat/launch-from-envar branch February 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants