feat: workflow enhancements for better tool results #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Enhanced Share Topology. Implement ModfiyCircularPattern.
mlkaplan36
requested review from
RobPasMue,
jonahrb,
jacobrkerstetter,
jrwest440 and
RyanJWard
|
Note: this PR will fail to build until the ApiServer side implementations are complete: https://tfs.ansys.com:8443/tfs/ANSYS_Development/CASL/_git/ApiServer/pullrequest/559034 |
RobPasMue
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Overall LGTM but I am concerned about code duplication with this PR. Also, we need to start handling quantities and measurement objects properly inside the tools and commands modules... Apart from "Real" we should also be accepting "Quantity" and "Distance"/"Angle" objects... but we can do this in a follow up PR to adapt all of them
Comment on lines
+767
to
+770
| step_angle : Real, default: 0.0 | ||
| Defines the circular angle | ||
| step_linear : Real, default: 0.0 | ||
| Defines the step, along the radial lines, for a pattern dimension greater than 1 |
There was a problem hiding this comment.
Suggested change
| step_angle : Real, default: 0.0 | |
| Defines the circular angle | |
| step_linear : Real, default: 0.0 | |
| Defines the step, along the radial lines, for a pattern dimension greater than 1 | |
| step_angle : Real, default: 0.0 | |
| Defines the circular angle. | |
| step_linear : Real, default: 0.0 | |
| Defines the step, along the radial lines, for a pattern dimension greater than 1. |
Comment on lines
+58
to
+61
|
|
||
|
|
||
| class EnhancedRepairToolMessage: | ||
| """Provides detailed return message for the repair tool methods.""" |
There was a problem hiding this comment.
Why not just modify the old RepairToolMessage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement EnhancedRepairToolMessage.
Implement Enhanced Share Topology.
Implement ModfiyCircularPattern.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)