Use yauzl instead of decompress for unzipping #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should test this in azuredatastudio fix (just replace the package.json entry with yours (or copy paste the code and overwrite what is there)). |
|
Yeah - I've been running it manually and it works fine (tested both install-ssmsmin and install-sqltoolsservice) |
|
I'll merge and publish a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issues seen where the extraction doesn't seem to actually be finished when the promise resolves.
There's an open issue in the repo indicating that we're not the only ones hitting this issue and since it's been years since it's been updated moving away from decompress seems prudent. kevva/decompress#62
Code adapted from VS Codes usage of the yauzl library : https://github.com/microsoft/vscode/blob/6ffa7d5887e60244169ef9699842ff276216be10/src/vs/base/node/zip.ts
Also added event for an entry being extracted from the zip for debugging/tracking purposes.