fix: webgl renderer has logical exception when updating attributes (#…

…1768) (#1769)
antvis · Sep 9, 2024 · 61ef85b · 61ef85b
1 parent e0f8abe
commit 61ef85b
Show file tree

Hide file tree

Showing 10 changed files with 43 additions and 2 deletions.
diff --git a/.changeset/healthy-boxes-train.md b/.changeset/healthy-boxes-train.md
@@ -0,0 +1,5 @@
+---
+'@antv/g-plugin-device-renderer': patch
+---
+
+fix: webgl renderer has logical exception when updating attributes
diff --git a/packages/g-plugin-device-renderer/src/drawcalls/Image.ts b/packages/g-plugin-device-renderer/src/drawcalls/Image.ts
@@ -174,6 +174,10 @@ export class ImageDrawcall extends Instanced {
     name: string,
     value: any,
   ) {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
 
     this.updateBatchedAttribute(objects, startIndex, name, value);

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/Instanced.ts b/packages/g-plugin-device-renderer/src/drawcalls/Instanced.ts
@@ -878,6 +878,16 @@ export abstract class Instanced {
         this.geometryDirty = true;
       }
     }
+
+    // fix https://github.com/antvis/G/issues/1768
+    if (this.geometryDirty === true && this.objects.length !== 0) {
+      if (this.geometry) {
+        this.geometry.destroy();
+      }
+      this.createGeometry(this.objects);
+
+      this.geometryDirty = false;
+    }
   }
 
   changeRenderOrder(object: DisplayObject, renderOrder: number) {

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/InstancedFill.ts b/packages/g-plugin-device-renderer/src/drawcalls/InstancedFill.ts
@@ -206,6 +206,10 @@ export class InstancedFillDrawcall extends Instanced {
     name: string,
     value: any,
   ): void {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
 
     this.updateBatchedAttribute(objects, startIndex, name, value);

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/InstancedLine.ts b/packages/g-plugin-device-renderer/src/drawcalls/InstancedLine.ts
@@ -371,6 +371,10 @@ export class InstancedLineDrawcall extends Instanced {
     name: string,
     value: any,
   ) {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
 
     this.updateBatchedAttribute(objects, startIndex, name, value);

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/InstancedPath.ts b/packages/g-plugin-device-renderer/src/drawcalls/InstancedPath.ts
@@ -338,6 +338,10 @@ export class InstancedPathDrawcall extends Instanced {
     name: string,
     value: any,
   ) {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
 
     this.updateBatchedAttribute(objects, startIndex, name, value);

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/Mesh.ts b/packages/g-plugin-device-renderer/src/drawcalls/Mesh.ts
@@ -30,6 +30,10 @@ export class MeshDrawcall extends Instanced {
     name: string,
     value: any,
   ): void {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
     this.updateBatchedAttribute(objects, startIndex, name, value);
   }

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/SDF.ts b/packages/g-plugin-device-renderer/src/drawcalls/SDF.ts
@@ -155,6 +155,10 @@ export class SDFDrawcall extends Instanced {
     name: string,
     value: any,
   ) {
+    if (objects.length === 0) {
+      return;
+    }
+
     super.updateAttribute(objects, startIndex, name, value);
 
     this.updateBatchedAttribute(objects, startIndex, name, value);

diff --git a/packages/g-plugin-device-renderer/src/drawcalls/Text.ts b/packages/g-plugin-device-renderer/src/drawcalls/Text.ts
@@ -347,6 +347,8 @@ export class TextDrawcall extends Instanced {
       return;
     }
 
+    super.updateAttribute(objects, startIndex, name, value);
+
     if (
       name === 'text' ||
       name === 'fontFamily' ||

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -1,14 +1,14 @@
 {
   "compilerOptions": {
-    "outDir": "./",
+    "rootDir": ".",
+    "outDir": ".",
     "module": "ESNext",
     "target": "es5",
     "jsx": "react",
     "moduleResolution": "node",
     "experimentalDecorators": true,
     "declaration": true,
     "sourceMap": true,
-    "sourceRoot": ".",
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
     "isolatedModules": true,
-Original file line number
+Diff line change
@@ Expand Up / @@ -347,6 +347,8 @@ export class TextDrawcall extends Instanced { @@
           return;
         }
+        super.updateAttribute(objects, startIndex, name, value);
         if (
           name === 'text' ||
           name === 'fontFamily' ||
@@ Expand Down @@