-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brevo webhook updates #387
Brevo webhook updates #387
Conversation
A question: while testing the new mappings, I noticed that Brevo had some problems with the proxy_open event. Hence, I contacted their support and I've received this as an answer:
Now, I am asking myself: should I also supply a mapping for It is undocumented and I've only gotten access to this by asking support. |
Thanks, your updates look great.
Yes. (I think.) I'd guess that We ended up normalizing both of the original "opened" to Anymail's OPENED, and added this paragraph to the docs about how to choose. See #344 if you're interested in the history.
I may get that printed on a T-shirt 😄. (Not to pick on Brevo: pretty much every ESP's documentation for webhooks is some combination of incomplete and just plain inaccurate.) |
Thanks for the feedback! I've now added the suggested changes. Let me know if something could be done better! |
That's great, thanks. I updated the docs to combine some of the earlier information about open events with your new information. (Also, nice work debugging Brevo's proxy open behavior and the missing |
Perfect! Thanks for merging those. Sounds way better that way.
Haha thanks. But that was more people work than debugging work. Their support was very helpful though. Wasn't more than 2-3 emails. |
rel #385
As talked about in the related issue, I've updated the mappings. I also added tests and docs.
Furthermore, I tried to make the code comment I missed ( "request" event) stand out more, by moving all the comments from inline to above their related entry. I hope this is OK.
Very much looking forward to your comments!