Feature cleanup: Removing unwanted rounding in fee calculation #21 #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
force-pushed
the
refactor-remove-feature-code-21
branch
2 times, most recently
from
135b4e8 to
2d0d7df
Compare
apfitzge
reviewed
Jan 29, 2025
fee/src/lib.rs
Outdated
| remove_rounding_in_fee_calculation(pub), | ||
| enable_secp256r1_precompile(pub) | ||
| ) | ||
| field_qualifiers(enable_secp256r1_precompile(pub)) |
There was a problem hiding this comment.
@tao-stones I have asked Pankaj to revert the change that introduced this change (only became aware of it due to this PR).
Would prefer a clean revert commit, so going to wait for his response to my comment before approving this PR.
tao-stones
force-pushed
the
refactor-remove-feature-code-21
branch
from
2d0d7df to
e840de3
Compare
apfitzge
approved these changes
Jan 30, 2025
pgarg66
approved these changes
Jan 30, 2025
|
can we please use more descriptive pr titles? "refactor" is inaccurate. no mention of which feature gate in the title. gonna be quite the spelunking mission to find this in 6mo+ |
tao-stones
changed the title
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Feature https://github.com/anza-xyz/feature-gate-tracker/issues/21 has activated everywhere.
Summary of Changes
Fixes #