Refactor - loader v4 SetProgramLength
#4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
Lichtso
commented
Jan 29, 2025
| @@ -200,10 +200,6 @@ fn process_instruction_truncate( | |||
| ic_logger_msg!(log_collector, "Program is not writeable"); | |||
| return Err(InstructionError::InvalidArgument); | |||
| } | |||
| if !program.is_signer() { | |||
There was a problem hiding this comment.
One has to assign loader-v4 as owner of the program account using the system program, which does check the program account being the signer.
Lichtso
force-pushed
the
refactor/loader_v4_set_program_length
branch
from
b8c0bfc to
ded5be8
Compare
LucasSte
previously approved these changes
Jan 29, 2025
Lichtso
force-pushed
the
refactor/loader_v4_set_program_length
branch
from
ded5be8 to
6208ab6
Compare
LucasSte
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #4661 (comment)
Summary of Changes
LoaderV4Instruction::TruncatetoLoaderV4Instruction::SetProgramLengthLoaderV4Instruction::SetProgramLength