encapsulates shred's payload type #4690
Merged
+242
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
changed the title
behzadnouri
force-pushed
the
shred-payload-encapsulate
branch
from
f7c0ccd to
27a4050
Compare
behzadnouri
added a commit
to behzadnouri/solana-program-slashing
that referenced
this pull request
Jan 29, 2025
anza-xyz/agave#4690 encapsulates the type of shred payload, and this code should use shred.payload().as_ref() instead of shred.payload().as_slice()
joncinque
pushed a commit
to solana-program/slashing
that referenced
this pull request
Jan 29, 2025
anza-xyz/agave#4690 encapsulates the type of shred payload, and this code should use shred.payload().as_ref() instead of shred.payload().as_slice()
behzadnouri
force-pushed
the
shred-payload-encapsulate
branch
from
27a4050 to
7955b0f
Compare
A wrapper type would allow to hide the implementation from the rest of the code-base and more easily roll-out changes.
behzadnouri
force-pushed
the
shred-payload-encapsulate
branch
from
7955b0f to
f8853eb
Compare
AshwinSekar
approved these changes
Jan 29, 2025
steviez
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A wrapper type would allow to hide the implementation from the rest of the code-base and more easily roll-out changes.
Summary of Changes
The commit defines:
as the new shred payload type.