removes Arc::unwrap_or_clone from StandardBroadcastRun::insert #4706
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broadcast stage wraps Vec<Shred> in Arc<...> to reduce allocations and cloning when shreds are concurrently sent to both BroadcastRun::record and BroadcastRun::transmit: https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage/standard_broadcast_run.rs#L224-L226 https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage.rs#L344 https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage.rs#L321 However, the unnecessary Arc::unwrap_or_clone in StandardBroadcastRun::insert breaks this memory sharing and forces a clone on shreds transmitted: https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage/standard_broadcast_run.rs#L370 The commit removes the unnecessary Arc::unwrap_or_clone and instead just skips the iterator of shreds by one when needed.
behzadnouri
force-pushed
the
rm-broadcast-unwrap-or-clone
branch
from
ac4c9fc to
f36cc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Broadcast stage wraps
Vec<Shred>inArcto reduce allocations and cloning when shreds are concurrently sent to bothBroadcastRun::recordandBroadcastRun::transmit:https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage/standard_broadcast_run.rs#L224-L226
https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage.rs#L344
https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage.rs#L321
However, the unnecessary
Arc::unwrap_or_cloneinStandardBroadcastRun::insertbreaks this memory sharing and forces a clone on shreds transmitted:https://github.com/anza-xyz/agave/blob/b59c1aee7/turbine/src/broadcast_stage/standard_broadcast_run.rs#L370
Summary of Changes
The commit removes the unnecessary
Arc::unwrap_or_cloneand instead just skips the iterator of shreds by one when needed.