Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ConsumeWorkerMetrics on 20ms interval #4708

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

apfitzge
Copy link

Problem

  • 1s interval is too large to report worker metrics
  • reporting on a 20s interval, many times per slot, gives us a picture of when and how things are processed as our leader slots progress

Summary of Changes

  • Report ConsumerWorkerMetrics on a 20ms interval
  • Gives us really great charts like this, showing how quickly we're able to fill blocks:
    image

Fixes #

@apfitzge apfitzge marked this pull request as ready for review January 30, 2025 20:28
@alessandrod
Copy link

backport?

@apfitzge apfitzge added the v2.1 Backport to v2.1 branch label Jan 31, 2025
@apfitzge apfitzge merged commit 5ad9124 into anza-xyz:master Jan 31, 2025
48 checks passed
Copy link

mergify bot commented Jan 31, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jan 31, 2025
alessandrod pushed a commit that referenced this pull request Feb 3, 2025
#4722)

Report ConsumeWorkerMetrics on 20ms interval (#4708)

(cherry picked from commit 5ad9124)

Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants