Skip to content

Commit

Permalink
remove enums
Browse files Browse the repository at this point in the history
  • Loading branch information
volar committed Jan 28, 2025
1 parent d50c728 commit 9e957ef
Show file tree
Hide file tree
Showing 15 changed files with 86 additions and 74 deletions.
24 changes: 13 additions & 11 deletions src/composables/system/assetDetailTab.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
import { ref } from 'vue'

export enum AssetDetailTab {
Info = 'meta',
ROI = 'roi',
Distribution = 'distribution',
Podcast = 'podcast',
VideoShow = 'videoShow',
Slots = 'slots',
ImagePreview = 'imagePreview',
Default = Info,
}
export const AssetDetailTab = {
Info: 'meta',
ROI: 'roi',
Distribution: 'distribution',
Podcast: 'podcast',
VideoShow: 'videoShow',
Slots: 'slots',
ImagePreview: 'imagePreview',
} as const

export type AssetDetailTabType = (typeof AssetDetailTab)[keyof typeof AssetDetailTab]
export const AssetDetailTabDefault = AssetDetailTab.Info

const activeTab = ref<AssetDetailTab>(AssetDetailTab.Default)
const activeTab = ref<AssetDetailTabType>(AssetDetailTabDefault)

export function useAssetDetailTab() {
return {
Expand Down
18 changes: 10 additions & 8 deletions src/composables/system/gridView.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
import { readonly, ref } from 'vue'

export enum GridView {
Masonry = 'masonry',
Thumbnail = 'thumbnail',
Table = 'table',
Default = Masonry,
}
export const GridView = {
Masonry: 'masonry',
Thumbnail: 'thumbnail',
Table: 'table',
} as const

export type GridViewType = (typeof GridView)[keyof typeof GridView]
export const GridViewDefault = GridView.Masonry

const gridView = ref<GridView>(GridView.Default)
const gridView = ref<GridViewType>(GridViewDefault)

export function useGridView() {
const setGridView = (value: GridView) => {
const setGridView = (value: GridViewType) => {
gridView.value = value
}

Expand Down
4 changes: 2 additions & 2 deletions src/model/coreDam/factory/PodcastEpisodeFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { DocIdNullable, IntegerId } from '@anzusystems/common-admin'
import { dateTimeNow } from '@anzusystems/common-admin'
import { ENTITY } from '@/services/api/coreDam/podcastEpisodeApi'
import { SYSTEM_CORE_DAM } from '@/model/systems'
import { PodcastLastImportStatus } from '@/model/coreDam/valueObject/PodcastLastImportStatus'
import { PodcastLastImportStatusDefault } from '@/model/coreDam/valueObject/PodcastLastImportStatus'

export function usePodcastEpisodeFactory() {
const createDefault = (extSystemId: IntegerId, podcastId: DocIdNullable = null): PodcastEpisode => {
Expand Down Expand Up @@ -31,7 +31,7 @@ export function usePodcastEpisodeFactory() {
extId: '',
rssUrl: '',
extUrl: '',
lastImportStatus: PodcastLastImportStatus.Default,
lastImportStatus: PodcastLastImportStatusDefault,
},
dates: {
publicationDate: null,
Expand Down
8 changes: 4 additions & 4 deletions src/model/coreDam/factory/PodcastFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import type { IntegerIdNullable } from '@anzusystems/common-admin'
import { dateTimeNow } from '@anzusystems/common-admin'
import { ENTITY } from '@/services/api/coreDam/podcastApi'
import { SYSTEM_CORE_DAM } from '@/model/systems'
import { PodcastMode } from '@/model/coreDam/valueObject/PodcastMode'
import { PodcastLastImportStatus } from '@/model/coreDam/valueObject/PodcastLastImportStatus'
import { PodcastModeDefault } from '@/model/coreDam/valueObject/PodcastMode'
import { PodcastLastImportStatusDefault } from '@/model/coreDam/valueObject/PodcastLastImportStatus'

export function usePodcastFactory() {
const createDefault = (licenceId: IntegerIdNullable = null): Podcast => {
Expand All @@ -18,8 +18,8 @@ export function usePodcastFactory() {
attributes: {
rssUrl: '',
extUrl: '',
mode: PodcastMode.Default,
lastImportStatus: PodcastLastImportStatus.Default,
mode: PodcastModeDefault,
lastImportStatus: PodcastLastImportStatusDefault,
webOrderPosition: 0,
mobileOrderPosition: 0,
},
Expand Down
22 changes: 12 additions & 10 deletions src/model/coreDam/valueObject/DistributionFailReason.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,21 @@ import { useI18n } from 'vue-i18n'
import { ref } from 'vue'
import type { ValueObjectOption } from '@anzusystems/common-admin'

export enum DistributionFailReason {
None = 'none',
Unknown = 'unknown',
QuotaReached = 'quota_reached',
RemoteProcessFailed = 'remote_process_failed',
ValidationFailed = 'validation_failed',
Default = None,
}
export const DistributionFailReason = {
None: 'none',
Unknown: 'unknown',
QuotaReached: 'quota_reached',
RemoteProcessFailed: 'remote_process_failed',
ValidationFailed: 'validation_failed',
} as const

export type DistributionFailReasonType = (typeof DistributionFailReason)[keyof typeof DistributionFailReason]
export const DistributionFailReasonDefault = DistributionFailReason.None

export function useDistributionFailReason() {
const { t } = useI18n()

const DistributionFailReasonOptions = ref<ValueObjectOption<DistributionFailReason>[]>([
const DistributionFailReasonOptions = ref<ValueObjectOption<DistributionFailReasonType>[]>([
{
value: DistributionFailReason.None,
title: t('coreDam.distribution.failReason.none'),
Expand All @@ -37,7 +39,7 @@ export function useDistributionFailReason() {
},
])

const getDistributionFailReasonOption = (value: DistributionFailReason) => {
const getDistributionFailReasonOption = (value: DistributionFailReasonType) => {
return DistributionFailReasonOptions.value.find((item) => item.value === value)
}

Expand Down
18 changes: 10 additions & 8 deletions src/model/coreDam/valueObject/ImageOrientation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@ import { ref } from 'vue'
import { useI18n } from 'vue-i18n'
import type { ValueObjectOption } from '@anzusystems/common-admin'

export enum ImageOrientation {
Landscape = 'L',
Portrait = 'P',
Square = 'S',
Default = Landscape,
}
export const ImageOrientation = {
Landscape: 'L',
Portrait: 'P',
Square: 'S',
} as const

export type ImageOrientationType = (typeof ImageOrientation)[keyof typeof ImageOrientation]
export const ImageOrientationDefault = ImageOrientation.Landscape

export function useImageOrientation() {
const { t } = useI18n()

const imageOrientationOptions = ref<ValueObjectOption<ImageOrientation>[]>([
const imageOrientationOptions = ref<ValueObjectOption<ImageOrientationType>[]>([
{
value: ImageOrientation.Landscape,
title: t('coreDam.asset.imageOrientation.landscape'),
Expand All @@ -27,7 +29,7 @@ export function useImageOrientation() {
},
])

const getImageOrientationOption = (value: ImageOrientation) => {
const getImageOrientationOption = (value: ImageOrientationType) => {
return imageOrientationOptions.value.find((item) => item.value === value)
}

Expand Down
18 changes: 10 additions & 8 deletions src/model/coreDam/valueObject/PodcastLastImportStatus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@ import { ref } from 'vue'
import { useI18n } from 'vue-i18n'
import type { ValueObjectOption } from '@anzusystems/common-admin'

export enum PodcastLastImportStatus {
NotImported = 'not_imported',
Imported = 'imported',
ImportFailed = 'import_failed',
Default = NotImported,
}
export const PodcastLastImportStatus = {
NotImported: 'not_imported',
Imported: 'imported',
ImportFailed: 'import_failed',
} as const

export type PodcastLastImportStatusType = (typeof PodcastLastImportStatus)[keyof typeof PodcastLastImportStatus]
export const PodcastLastImportStatusDefault = PodcastLastImportStatus.NotImported

export function usePodcastLastImportStatus() {
const { t } = useI18n()

const podcastLastImportStatusOptions = ref<ValueObjectOption<PodcastLastImportStatus>[]>([
const podcastLastImportStatusOptions = ref<ValueObjectOption<PodcastLastImportStatusType>[]>([
{
value: PodcastLastImportStatus.NotImported,
title: t('coreDam.podcast.lastImportStatus.notImported'),
Expand All @@ -27,7 +29,7 @@ export function usePodcastLastImportStatus() {
},
])

const getPodcastLastImportStatusOption = (value: PodcastLastImportStatus) => {
const getPodcastLastImportStatusOption = (value: PodcastLastImportStatusType) => {
return podcastLastImportStatusOptions.value.find((item) => item.value === value)
}

Expand Down
16 changes: 9 additions & 7 deletions src/model/coreDam/valueObject/PodcastMode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,18 @@ import { ref } from 'vue'
import { useI18n } from 'vue-i18n'
import type { ValueObjectOption } from '@anzusystems/common-admin'

export enum PodcastMode {
Import = 'import',
NotImport = 'not_import',
Default = Import,
}
export const PodcastMode = {
Import: 'import',
NotImport: 'not_import',
} as const

export type PodcastModeType = (typeof PodcastMode)[keyof typeof PodcastMode]
export const PodcastModeDefault = PodcastMode.Import

export function usePodcastMode() {
const { t } = useI18n()

const podcastModeOptions = ref<ValueObjectOption<PodcastMode>[]>([
const podcastModeOptions = ref<ValueObjectOption<PodcastModeType>[]>([
{
value: PodcastMode.Import,
title: t('coreDam.podcast.podcastMode.import'),
Expand All @@ -22,7 +24,7 @@ export function usePodcastMode() {
},
])

const getPodcastModeOption = (value: PodcastMode) => {
const getPodcastModeOption = (value: PodcastModeType) => {
return podcastModeOptions.value.find((item) => item.value === value)
}

Expand Down
4 changes: 2 additions & 2 deletions src/types/coreDam/Distribution.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { DistributionFailReason } from '@/model/coreDam/valueObject/DistributionFailReason'
import type { DistributionFailReasonType } from '@/model/coreDam/valueObject/DistributionFailReason'
import type { DistributionYoutubePrivacy } from '@/model/coreDam/valueObject/DistributionYoutubePrivacy'
import type {
DamDistributionServiceName,
Expand Down Expand Up @@ -55,7 +55,7 @@ export interface DistributionItem {
extId: string
distributionService: DamDistributionServiceName
status: DamDistributionStatusType
failReason: DistributionFailReason
failReason: DistributionFailReasonType
blockedBy: DocId[]
publishAt: DatetimeUTCNullable
_resourceName: string
Expand Down
8 changes: 4 additions & 4 deletions src/types/coreDam/Podcast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import type {
IntegerIdNullable,
ResourceNameSystemAware,
} from '@anzusystems/common-admin'
import type { PodcastMode } from '@/model/coreDam/valueObject/PodcastMode'
import type { PodcastLastImportStatus } from '@/model/coreDam/valueObject/PodcastLastImportStatus'
import type { PodcastModeType } from '@/model/coreDam/valueObject/PodcastMode'
import type { PodcastLastImportStatusType } from '@/model/coreDam/valueObject/PodcastLastImportStatus'

interface Texts {
title: string
Expand All @@ -25,8 +25,8 @@ export interface Attributes {
extUrl: string
webOrderPosition: number
mobileOrderPosition: number
mode: PodcastMode
lastImportStatus: PodcastLastImportStatus
mode: PodcastModeType
lastImportStatus: PodcastLastImportStatusType
}

interface Dates {
Expand Down
4 changes: 2 additions & 2 deletions src/types/coreDam/PodcastEpisode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {
DocIdNullable,
ResourceNameSystemAware,
} from '@anzusystems/common-admin'
import type { PodcastLastImportStatus } from '@/model/coreDam/valueObject/PodcastLastImportStatus'
import type { PodcastLastImportStatusType } from '@/model/coreDam/valueObject/PodcastLastImportStatus'

interface Texts {
title: string
Expand All @@ -30,7 +30,7 @@ interface Attributes {
extId: string
extUrl: string
rssUrl: string
lastImportStatus: PodcastLastImportStatus
lastImportStatus: PodcastLastImportStatusType
}

interface Dates {
Expand Down
4 changes: 2 additions & 2 deletions src/views/coreDam/asset/detail/AssetDetailView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { type DocId, isDocId, isString, useAlerts, useDamCachedUsers, useTheme }
import { useAssetDetailStore } from '@/stores/coreDam/assetDetailStore'
import { storeToRefs } from 'pinia'
import AssetImageRoiSelect from '@/views/coreDam/asset/detail/components/AssetImageRoiSelect.vue'
import { AssetDetailTab, useAssetDetailTab } from '@/composables/system/assetDetailTab'
import { AssetDetailTab, AssetDetailTabDefault, useAssetDetailTab } from '@/composables/system/assetDetailTab'
import AssetImage from '@/views/coreDam/asset/components/AssetImage.vue'
import AssetDetailDialogSidebar from '@/views/coreDam/asset/detail/components/AssetDetailDialogSidebar.vue'
import { fetchAsset } from '@/services/api/coreDam/assetApi'
Expand Down Expand Up @@ -83,7 +83,7 @@ const getDetail = async () => {
const resetAllStores = () => {
assetDetailStore.hideDetail()
assetDetailStore.reset()
activeTab.value = AssetDetailTab.Default
activeTab.value = AssetDetailTabDefault
assetDetailStore.directDetailLoad = false
assetListStore.reset()
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<script lang="ts" setup>
import { computed } from 'vue'
import {
type DistributionFailReason,
type DistributionFailReasonType,
useDistributionFailReason,
} from '@/model/coreDam/valueObject/DistributionFailReason'
const props = withDefaults(
defineProps<{
status: DistributionFailReason
status: DistributionFailReasonType
}>(),
{}
)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<script lang="ts" setup>
import { computed } from 'vue'
import {
type PodcastLastImportStatus,
type PodcastLastImportStatusType,
usePodcastLastImportStatus,
} from '@/model/coreDam/valueObject/PodcastLastImportStatus'
import { AChipNoLink } from '@anzusystems/common-admin'
const props = withDefaults(
defineProps<{
status: PodcastLastImportStatus
status: PodcastLastImportStatusType
}>(),
{}
)
Expand Down
4 changes: 2 additions & 2 deletions src/views/coreDam/podcast/components/PodcastModeChip.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<script lang="ts" setup>
import { computed } from 'vue'
import { type PodcastMode, usePodcastMode } from '@/model/coreDam/valueObject/PodcastMode'
import { type PodcastModeType, usePodcastMode } from '@/model/coreDam/valueObject/PodcastMode'
import { AChipNoLink } from '@anzusystems/common-admin'
const props = withDefaults(
defineProps<{
mode: PodcastMode
mode: PodcastModeType
}>(),
{}
)
Expand Down

0 comments on commit 9e957ef

Please sign in to comment.