-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass specific env vars to logGroomerSideCar #45483
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Can you add it to other logGroomer we have, and add tests here? |
@@ -264,6 +264,7 @@ spec: | |||
{{- if .Values.scheduler.logGroomerSidecar.args }} | |||
args: {{- tpl (toYaml .Values.scheduler.logGroomerSidecar.args) . | nindent 12 }} | |||
{{- end }} | |||
envFrom: {{- include "custom_airflow_environment_from" . | default "\n []" | indent 10 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a little weird to include the custom env if we aren't also including the standard env.
There is also #46003 that was opened to allow custom env vars just for the log groomers, which is probably a better answer.
In our deployment we need to pass specific environment variables to logGroomerSidecar in both scheduler and triggered versions. This is a proposal to add them using envFrom.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.