Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Data Models for Bulk Actions in Rest API (FastAPI) #46033

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

bugraoz93
Copy link
Collaborator

@bugraoz93 bugraoz93 commented Jan 25, 2025

closes: #45816

This could potentially help to unify actions for most of the CRUD endpoints for entities using services and common actions.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 25, 2025
@bugraoz93 bugraoz93 changed the title Unify datamodels and services for bulk endpoints Unify Data Models for Bulk Actions in Rest API (FastAPI) Jan 25, 2025
@bugraoz93 bugraoz93 added the area:API Airflow's REST/HTTP API label Jan 25, 2025
@bugraoz93
Copy link
Collaborator Author

CC: @shubhamraj-git

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good consolidation for me. +1 for a PR reducing LOC in the code base!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@potiuk potiuk merged commit 1ef2b6c into apache:main Jan 26, 2025
45 checks passed
vatsrahul1001 pushed a commit to astronomer/airflow that referenced this pull request Jan 27, 2025
* Unify datamodels and services for bulk endpoints

* Remove commented code pieces
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jan 27, 2025
@utkarsharma2 utkarsharma2 added this to the Airflow 3.0.0 milestone Jan 27, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Unify datamodels and services for bulk endpoints

* Remove commented code pieces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Data Models for Bulk Actions in Rest API (FastAPI)
4 participants