Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add #END to the debug.yaml basic snippet #10549

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Conversation

nfrankel
Copy link
Contributor

Description

The debug.yaml needs a trailing #END (just like the routes.yaml)

The first sample misses it. This PR fixes it.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

The debug.yaml needs a trailing #END (just like the routes.yaml)

The first sample misses it. This PR fixes it.
@nfrankel nfrankel requested a review from pottekkat November 24, 2023 15:38
@nfrankel nfrankel changed the title Add #END to the basic snippet docs: Add #END to the basic snippet Nov 24, 2023
@kayx23 kayx23 changed the title docs: Add #END to the basic snippet docs: Add #END to the debug.yaml basic snippet Nov 24, 2023
@kayx23 kayx23 merged commit 56a6c98 into release/3.7 Nov 25, 2023
12 checks passed
@kayx23 kayx23 deleted the nfrankel-patch-1 branch November 25, 2023 05:24
@kayx23
Copy link
Member

kayx23 commented Nov 25, 2023

Sigh just noticed this was going into the 3.7 branch. This change should be merged into master as well so it gets carried over to future releases.

kayx23 pushed a commit that referenced this pull request Nov 30, 2023
…0565)

* docs: Add #END to the `debug.yaml` basic snippet (#10549)

* Update load-balancing.md

modify load-balancing effect command line

* Update rate-limiting.md

* Update rate-limiting.md in zh

* Update load-balancing.md in zh

---------

Co-authored-by: Nicolas Fränkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants