Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow workflow config without case #11787

Merged
merged 4 commits into from
Nov 29, 2024
Merged

feat: allow workflow config without case #11787

merged 4 commits into from
Nov 29, 2024

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Nov 28, 2024 •
edited
Loading

Description

This change makes case a non required field and an absence of case will be considered default match.### Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 28, 2024
@Revolyssup Revolyssup requested a review from nic-6443 November 28, 2024 08:34
@Revolyssup Revolyssup merged commit ee6a04c into apache:master Nov 29, 2024
33 checks passed
@Revolyssup Revolyssup deleted the revolyssup/backport/workflow branch November 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@moonming moonming moonming approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

@membphis membphis Awaiting requested review from membphis

Assignees
No one assigned
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Revolyssup @nic-6443 @moonming @shreemaan-abhishek