-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36243: [Dev] Remove PR workflow label as part of merge #36244
Conversation
|
@pitrou I think you asked for this in the past. I can do a cleanup of labels once this is merged so we remove them from closed PRs. |
@@ -418,11 +418,23 @@ def merge_pr(self, number, commit_title, commit_message): | |||
} | |||
response = requests.put(url, headers=self.headers, json=payload) | |||
result = response.json() | |||
if response.status_code != 200 and 'merged' not in result: | |||
if response.status_code == 200 and 'merged' in result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw based on the API if the result is 200 the merge was successful and merged
will always be true.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#merge-a-pull-request
I am sure we can mark this as False
if those are not successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Conbench analyzed the 6 benchmark runs on commit There were 8 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
Those labels are unnecessary once they are merged. There was a conversation on Zulip about removing them in the past.
What changes are included in this PR?
Once we merge a PR we remove labels that starts with the PR workflow prefix
awaiting
.Are these changes tested?
I have tested the code against an old testing PR I have here: #35323
The label was removed successfully.
Are there any user-facing changes?
No