Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AXIS2-5858 #842

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix AXIS2-5858 #842

wants to merge 3 commits into from

Conversation

cortlepp
Copy link
Member

See discussion in Jira.

@cortlepp
Copy link
Member Author

@robertlazarski can you restart the build? From the stacktrace it seems like this to just be some dns resolution failure, but I don't see how I can restart the build.

@cortlepp
Copy link
Member Author

If possible I'd like to also add tests for this, but I'm unsure where/how. If someone has an idea that would be great.

@cortlepp
Copy link
Member Author

There seems to be a problem in the TCPEchoRawXMLTest, for some hard to debug reason the TCP server keeps shutting down soon after or as soon as we try to connect to it. Unfortunately I have no idea why this could be the case and I'm having a really hard time getting any sensible logs out of this the server.

@robertlazarski
Copy link
Contributor

@cortlepp I reviewed the builds and code, with a conclusion that map(InetAddress::getHostAddress) instead of map(InetAddress::toString) in getIpAddress() will fix the issue as the latter includes the hostname or simply / as a leading char.

The logging of unit tests can be problematic, so I temporarily insert System.out.println() statements and found the problem that way.

@cortlepp
Copy link
Member Author

@robertlazarski Thanks so much for looking into this! Do you perhaps have any idea how/where I can add a good test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants