Add a script to help verify release checks #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
7b895cd to
1019ac5
Compare
| ################### | ||
|
|
||
| mkdir -p /tmp/$1 | ||
| cd /tmp/$1 |
There was a problem hiding this comment.
An improvement to this script would be to use a docker container instead of the /tmp directory.
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
2 times, most recently
from
0d0d6da to
2615841
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
2615841 to
832cb22
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
832cb22 to
1d90352
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
1d90352 to
4ea68da
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
4ea68da to
5e6a4a3
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
5e6a4a3 to
fc22ab0
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
fc22ab0 to
c316892
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
2 times, most recently
from
029d0ab to
12e7d81
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
4 times, most recently
from
88e8e13 to
4b2f607
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
4b2f607 to
dbf5d81
Compare
Mmuzaf
reviewed
Jul 24, 2023
| echo "====== CHECK RESULTS ======" | ||
| echo | ||
|
|
||
| gpg --import KEYS |
There was a problem hiding this comment.
I think it spoils the local gpg agent in case we don't want to import all the keys locally, so it should probably run inside a docker or we can prepare a docker image to do all checks :-)
Mmuzaf
reviewed
Jul 24, 2023
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
3 times, most recently
from
77e2240 to
3dad685
Compare
Mmuzaf
reviewed
Aug 14, 2023
| command -v timeout >/dev/null 2>&1 || { echo >&2 "timeout needs to be installed"; exit 1; } | ||
| command -v docker >/dev/null 2>&1 || { echo >&2 "docker needs to be installed"; exit 1; } | ||
| (docker info >/dev/null 2>&1) || { echo >&2 "docker needs to running"; exit 1; } | ||
| (java -version 2>&1 | grep -q "1.8") || { echo >&2 "Java 8 must be used"; exit 1; } |
There was a problem hiding this comment.
I think we can remove this requirement as it will not work for 5.x releases, right? :-)
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
3dad685 to
bed5d51
Compare
smiklosovic
reviewed
Aug 15, 2023
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
bed5d51 to
0e53ce4
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
0e53ce4 to
5996107
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
5996107 to
f5a33a8
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
4 times, most recently
from
b119a93 to
52bc067
Compare
|
Additions added so releases after they have been published can also be checked. |
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
8 times, most recently
from
d859b6e to
333a269
Compare
michaelsembwever
force-pushed
the
mck/release-verification-script
branch
from
333a269 to
ab9a662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.