tools/assertions: fail if exception does not match #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, we fail the test if repr(e) does not match with the given
matching
regular expression. despite that the tests pass as expected, this is what we intend to complete with this verification. let's explain this with a Python REPL session:repr()
returns a canonical string representation of an object. that's why it adds "Exception()" around the error message. and, it fails to match with the the "matching" string. as "Exception('foobarhello')" does not match at the beginning of this string. but we actually expect the unmatch! in other words, two negatives make a positive.to correct this, in this change: