Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align tests with CASSANDRA-19335 #261

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

zaaath
Copy link

@zaaath zaaath commented May 12, 2024

CASSANDRA-19335, introduced in PR#3069, implements the following changes:

  1. By default, nodetool tablestats now outputs byte sizes with human-readable suffixes (e.g., "bytes", "KiB", "MiB"). This update has caused several dtests to fail, as detailed in this CircleCI report.
  2. A new CLI flag, -r or --no-human-readable, has been added to nodetool tablestats to revert to the non-human-readable byte size output, maintaining compatibility with existing parsing logic.

Backwards Compatibility:

  • Versions of nodetool prior to PR#3069 may not recognize the -r CLI flag, leading to potential test failures.

Further Work:

  • Implement JSON / YAML output options for nodetool tablestats and update dtests to parse these formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant