Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace fs-extra with node:fs #1772

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

erisu
Copy link
Member

@erisu erisu commented Jan 28, 2025

Platforms affected

n/a

Motivation and Context

Replace fs-extra dependency with node internals node:fs

Description

Remove fs-extra and updated code to require and use node:fs APIs.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 14.0.0 milestone Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (b623311) to head (9206f11).

Files with missing lines Patch % Lines
lib/prepare.js 55.55% 4 Missing ⚠️
lib/builders/ProjectBuilder.js 71.42% 2 Missing ⚠️
lib/pluginHandlers.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1772   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          23       23           
  Lines        1837     1837           
=======================================
  Hits         1332     1332           
  Misses        505      505           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a project and ran prepare & build with this locally and it all seems to be working 👍

@erisu erisu merged commit e012478 into apache:master Jan 29, 2025
14 checks passed
@erisu erisu deleted the refactor/remove-fs-extra branch January 29, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants