-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.12.0-rc2 #956
Conversation
@@ -41,7 +41,6 @@ force_hash_collisions = ["datafusion/force_hash_collisions"] | |||
hdfs = ["datafusion-objectstore-hdfs/hdfs"] | |||
hdfs3 = ["datafusion-objectstore-hdfs/hdfs3"] | |||
s3 = ["object_store/aws"] | |||
simd = ["datafusion/simd"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataFusion no longer has a simd feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simd feature was removed from arrow-rs in:
commit d41e90e31d07bc2ad2f05ffc091f171e6c846ddf
Author: Raphael Taylor-Davies <[email protected]>
Date: Fri Dec 8 08:49:46 2023 +0000
Remove SIMD Feature (#5184)
* Remove SIMD feature
* Clippy
* Tweak WASM features
* Fix test
* Exclude pyarrow from general build
There are commits prior to this with statements such as:
* Refactor numeric aggregation kernels to make better use of
auto-vectorization.
Remove the explicit simd implementations since the autovectorized
versions are faster on average.
@avantgardnerio @Dandandan I plan on merging this when CI passes and will then cut a new RC |
@@ -41,7 +41,6 @@ force_hash_collisions = ["datafusion/force_hash_collisions"] | |||
hdfs = ["datafusion-objectstore-hdfs/hdfs"] | |||
hdfs3 = ["datafusion-objectstore-hdfs/hdfs3"] | |||
s3 = ["object_store/aws"] | |||
simd = ["datafusion/simd"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened?
Which issue does this PR close?
Closes #926
Rationale for this change
0.12.0-rc1 failed because we are pinned to a non-release version of DataFusion. We will need to wait for the imminent 35.0.0 release.
What changes are included in this PR?
Pin to newer version. I will update this PR once DF 35.0.0 is released.
Are there any user-facing changes?