Allow IT Dockerfile to exit after all setup attempts fail #17592
Conversation
GWphua
changed the title
|
PTAL @Akshat-Jain @cryptoe |
There was a problem hiding this comment.
LGTM, was able to confirm the new behaviour at https://github.com/apache/druid/actions/runs/12429974963/job/34707262605?pr=17592
| rm -f /root/base-setup.sh | ||
| rm -f /root/base-setup.sh; \ | ||
| if [ "$i" -eq "$SETUP_RETRIES" ]; then \ | ||
| exit 1; \ |
There was a problem hiding this comment.
Lets put a message here mentioning gave up on retries.
There was a problem hiding this comment.
Message like
Tried [$i] times to contact [$url]. Unable to do so. Try a different url or check connectivity
There was a problem hiding this comment.
this seems like a fix-of-the-fix already #17543
I think this retry logic is completely misplaced; it seems to me that the original problem was that wget times out?
I think running all steps of the script will retry it even if other issues happen ...
I wonder why not specify some retry conditions for wget instead ?
https://unix.stackexchange.com/questions/227665/wget-abort-retrying-after-failure-or-timeout
Description
Presently the Integration Test Dockerfile continues execution even after 3 failures of
base-setup.sh, and do not exit immediately. This PR aims to patch that up, by forcing Docker to exit after 3 failures.This PR has: