Code Coverage additions for Extensions #17596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Metrics/Event Emitting
Area - Dependencies
Area - MSQ
kfaraz
reviewed
Jan 6, 2025
| public class SSLContextProviderTest | ||
| { | ||
| @Mock | ||
| private SSLClientConfig mockConfig; |
There was a problem hiding this comment.
Why not create a concrete object instead of using a mock?
| String expectedKeyManagerFactoryAlgorithm = "SunX509"; | ||
| Boolean expectedValidateHostnames = true; | ||
|
|
||
| // Use reflection to set the private fields |
There was a problem hiding this comment.
Please don't use reflection for this.
Either
- add a constructor
- OR, override the getters to return the expected values
- OR, deserialize the object from a json string
| } | ||
|
|
||
| @Test | ||
| public void testToString() |
There was a problem hiding this comment.
Do we really need to test the toString method? AFAICT, the toString of this class is used only for debug logging.
| } | ||
|
|
||
| @Test | ||
| public void testToString() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extensions-coreandextensions-contribdirectoriesRelease note
Key changed/added classes in this PR
extensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfigTest.javaextensions-contrib/prometheus-emitter/src/test/java/org/apache/druid/emitter/prometheus/PrometheusEmitterTest.javaextensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/MSQTaskListTest.javaextensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/MSQTuningConfigTest.javaextensions-core/simple-client-sslcontext/pom.xmlextensions-core/simple-client-sslcontext/src/test/java/org/apache/druid/https/SSLClientConfigTest.javaextensions-core/simple-client-sslcontext/src/test/java/org/apache/druid/https/SSLContextProviderTest.javaThis PR has: