[FLINK-36210] Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akatona84
reviewed
Sep 5, 2024
| static Map<String, TopicDescription> getTopicMetadata(AdminClient adminClient, Pattern topicPattern) { | ||
| try { | ||
| Set<String> allTopicNames = adminClient.listTopics().names().get(); | ||
| Set<String> patternTopicNames = allTopicNames.stream() |
There was a problem hiding this comment.
nit: matchedTopic* would sound nicer than patternTopic* (not just here, in the whole pr)
There was a problem hiding this comment.
nit: matchedTopic* would sound nicer than patternTopic* (not just here, in the whole pr)
Thank you for your careful review, I changed to them.
There was a problem hiding this comment.
nit: matchedTopic* would sound nicer than patternTopic* (not just here, in the whole pr)
done.
|
Friendly ping, do you have time to take a look @AHeise 🙏 ? |
AHeise
reviewed
Sep 9, 2024
|
Don't forget to run spotless. |
Thanks for the reminder! |
done. |
|
Awesome work, congrats on your first merged pull request! |
|
Merged, thank you for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Optimize the logic for fetching topic metadata in the TopicPatternSubscriber mode to speed up task recovery.
Brief change log
In
TopicPatternSubscribermode, our current logic for fetch topic metadata for all topics and then filtering it. We can optimize this by first filtering the topic names and then fetch metadata only for the filtered topics.Verifying this change
Documentation