Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36832] Remove Deprecated classes and relevant tests. #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lvyanquan
Copy link

Remove Deprecated classes and relevant tests, and annotated some classes from Deprecated to Internal.

Copy link

boring-cyborg bot commented Dec 3, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@lvyanquan
Copy link
Author

Hi, @PatrickRen @AHeise. Could you please help to review this?

@AHeise
Copy link
Contributor

AHeise commented Dec 16, 2024

Hi @lvyanquan , thank you very much for tackling the release. Unfortunately, I don't have time to review it this year and per prior agreement, I expected @PatrickRen and @leonardBang to pick this up. I will ping them again on slack.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvyanquan for the PR, I left one comment

import java.util.UUID;

/** IT cases for Kafka. */
public class KafkaITCase extends KafkaConsumerTestBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have new test/ITCase which bases on new API that covers these cases ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have independent test for new Source/SInk API in KafkaSinkITCase and KafkaSourceITCase, but I don't see they are equivalent to the previous testing scenarios, these new tests are designed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants