-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35196] [Connector / Pulsar] Fix bouncycastle class not found #91
[FLINK-35196] [Connector / Pulsar] Fix bouncycastle class not found #91
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
415cbad
to
5548950
Compare
@syhily @snuyanzin @tsreaper PTAL. Thanks. |
Thanks for your commit. I think |
@syhily Thanks review. I have upgraded |
The pulsar-client-all should be upgrade to the 3.0.4 in the mean time. |
@syhily sure. I have addressed. |
@syhily After So I think it is worth using a separate PR to upgrade pulsar-client-all to version 3.0.4 and solve the problems caused by the related upgrade. This PR only solves the problem that the table api cannot find the bouncycastle class. Related error logs: PTAL. Thanks. |
133792f
to
8e25db1
Compare
Thanks for your works. I think we can divide the work into two steps. Bump pulsar-client-all do require a lot of works. But since the pulsar-client-all depends on the legacy 15on. I think we can exclude these dependencies first in this PR and use 18on. |
@syhily ignore this problem. Thanks. |
OK, feel free to reopen this PR if you need. |
Purpose of the change
The
bouncycastle
dependency was removed in this PR [FLINK-30430][Connector/Pulsar] Remove all the useless dependencies, drop mock runtime. #9 , which was correct at the time, and there was no table api at that timeWhen we introduced table api, dependencies started to show errors because bouncycastle was referenced in table api