Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hive 3.0.0 connector #709

Open
wants to merge 1 commit into
base: asf-site
Choose a base branch
from
Open

Conversation

snuyanzin
Copy link
Contributor

No description provided.

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

source_release_url: "https://www.apache.org/dyn/closer.lua/flink/flink-connector-hive-3.0.0/flink-connector-hive-3.0.0-src.tgz"
source_release_asc_url: "https://downloads.apache.org/flink/flink-connector-hive-3.0.0/flink-connector-hive-3.0.0-src.tgz.asc"
source_release_sha512_url: "https://downloads.apache.org/flink/flink-connector-hive-3.0.0/flink-connector-hive-3.0.0-src.tgz.sha512"
compatibility: ["1.18.x"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.20.x now?

Copy link
Contributor

@leonardBang leonardBang Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatibility: ["1.19.x", "1.20.x"], @snuyanzin @lvyanquan We should keep at least two flink major versions' compatibility, and I noted the apache/flink-connector-hive@204c8bd breakout this rule, please double check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But as this is the first external release of hive connector, the hive connector for flink 1.19.x and 1.20.x has been released together with flink 1.20 ,I agree that 1.20.x is enough here.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge after the comments are addresseed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants